Re: [PATCH] pinctrl: cherryview: Mask all interrupts on Intel_Strago based systems

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Fri, Dec 01, 2017 at 02:35:32PM +0200, Andy Shevchenko wrote:
> On Fri, 2017-12-01 at 13:25 +0300, Mika Westerberg wrote:
> > Guenter Roeck reported an interrupt storm on a prototype system which
> > is
> > based on Cyan Chromebook. The root cause turned out to be a
> > incorrectly
> > configured pin that triggers spurious interrupts. This will be fixed
> > in
> > coreboot but currently we need to prevent the interrupt storm from
> > happening by masking all interrupts (but not GPEs) on those systems.
> > 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=194945
> 
> Shouldn't be this URL to the bug mentioned in the comments below?

Doh! Yes, it should. I'll fix it up.

> > +	/*
> > +	 * The same set of machines in chv_no_valid_mask[] have
> > incorrectly
> > +	 * configured GPIOs that generate spurious interrupts so we
> > use
> > +	 * this same list to apply another quirk for them.
> > +	 *
> > +	 * See also https://bugzilla.kernel.org/show_bug.cgi?id=19795
> > 3.
> > +	 */
> 
> > +		chv_writel(~(BIT(pctrl->community->nirqs) - 1),
> > +			   pctrl->regs + CHV_INTMASK);
> 
> It might be considered to use
> 
> GENMASK(32, pctrl->community->nirqs)
> 
> instead of
> 
> ~(BIT(pctrl->community->nirqs) - 1)

Indeed it looks better with GENMASK() so I'll change it in the next
version.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html