On Thu, Nov 23, 2017 at 6:13 PM, Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > +config MFD_MADERA_I2C > + bool "Cirrus Logic Madera codecs with I2C" > + select MFD_MADERA > + select REGMAP_I2C > + depends on I2C > + depends on PINCTRL > + help > + Support for the Cirrus Logic Madera platform audio SoC > + core functionality controlled via I2C. > + > +config MFD_MADERA_SPI > + bool "Cirrus Logic Madera codecs with SPI" > + select MFD_MADERA > + select REGMAP_SPI > + depends on SPI_MASTER > + depends on PINCTRL > + help > + Support for the Cirrus Logic Madera platform audio SoC > + core functionality controlled via SPI. Why do the I2C and SPI subdrivers depend on PINCTRL? They sure don't seem to be using any pinctrl-specific APIs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html