Re: [PATCH 0/2] GPIO support for Socionext Synquacer

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Oct 27, 2017 at 10:21 PM, Ard Biesheuvel
<ard.biesheuvel@xxxxxxxxxx> wrote:

> The Socionext Synquacer SC2A11, which is used in the arm64 Developer Box,
> shares its GPIO IP with a Fujitsu SoC for which we already have support
> in the tree. So let's tweak it so that we can reuse it.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Ard Biesheuvel (2):
>   gpio: mb86s7x: share with other SoCs as module
>   gpio: mb86s70: Revert "Return error if requesting an already assigned
>     gpio"

Nice. We might need to look into the following wrt this driver:

- Using generic MMIO GPIO, i.e. select GPIO_GENERIC in Kconfig
  and a patch such as commit 6d125412fc16802012a17665638f49b0b0c81f18
  "gpio: iop: Use generic GPIO MMIO functions for driver"
  apart from reduced code size this brings the .get_multiple() and
  .set_multiple() callbacks for FREE.
  The fact that the driver is so simple that it should have been using
  MMIO/GENERIC GPIO is a plain oversight during review.

- When submitting the DTS for that developer box, make sure that
  the 96boards header has proper GPIO line names from day 1,
  see e.g.
  commit bbaf867e2d3796bca465d07ffcd800a3bd570861
  "arm64: dts: hikey: name the GPIO lines"

Ard: if you have this machine on your desk help with the above would
be much appreciated (plus it's fun!) thanks a bunch :)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html