Hi,
On Fri, Oct 06, 2017 at 01:08:11PM +0800, Phil Reid wrote:
> Variable mask and val are not used in the mcp_pinconf_set().
>
> Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>
Thanks, those are leftovers from before I added mcp_set_bit.
Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>
-- Sebastian
> ---
> drivers/pinctrl/pinctrl-mcp23s08.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
> index 8dceaa1..8e461cc 100644
> --- a/drivers/pinctrl/pinctrl-mcp23s08.c
> +++ b/drivers/pinctrl/pinctrl-mcp23s08.c
> @@ -279,8 +279,7 @@ static int mcp_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
> {
> struct mcp23s08 *mcp = pinctrl_dev_get_drvdata(pctldev);
> enum pin_config_param param;
> - u32 arg, mask;
> - u16 val;
> + u32 arg;
> int ret = 0;
> int i;
>
> @@ -290,8 +289,6 @@ static int mcp_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
>
> switch (param) {
> case PIN_CONFIG_BIAS_PULL_UP:
> - val = arg ? 0xFFFF : 0x0000;
> - mask = BIT(pin);
> ret = mcp_set_bit(mcp, MCP_GPPU, pin, arg);
> break;
> default:
> --
> 1.8.3.1
>
Attachment:
signature.asc
Description: PGP signature
