Re: [PATCH] pinctrl: sh-pfc: r8a7795: add I2C pin support

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Wed, Oct 4, 2017 at 5:52 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Since pinmuxing for I2C is equal on H3 ES1.0 and later versions, copy
> the I2C settings from ES1.0. Fixes this error in upstream for
> Salvator-XS:
>
> sh-pfc e6060000.pin-controller: function 'i2c2' not supported
> sh-pfc e6060000.pin-controller: invalid function i2c2 in map table
> i2c-rcar: probe of e6510000.i2c failed with error -22
>
> Now, the bus works the same as with other Salvator boards.

Thanks for your patch!

> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in sh-pfc-for-v4.15.

> This patch is based on top of Geert's sh-pfc branch. I'd think it is a bugfix
> for the above reasons and it would be really great to have it in v4.14. But you
> guys will have the final word, of course.

I tend to disagree: this is just part of the normal process of adding hardware
support incrementally.

While in this particular case hardware got (partially) enabled early due to
.dtsi sharing, the same could have happened without sharing, as DT and PFC
patches go in through different channels, and could arrive upstream in
different released versions.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html