Re: [PATCH] gpio: syscon: do not use raw "set" callback in syscon_gpio_dir_out

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 21, 2017 at 1:56 PM, Alexander Shiyan <shc_work@xxxxxxx> wrote:
>>Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij <linus.walleij@xxxxxxxxxx>:
>>
>>I really need Alexander Shiyan to look at this patch.
>>
>>The way i percieve it, .set is NULL if the chip does not
>>support output.
>>
>>We should print the right error messages and bail out
>>if the user is anyway trying to set a line like that.
>
> Hello.
>
> Using "chip->set", instead of "priv->data->set", is more proper way on my opinion.
> However, if the driver is not configured for output, the any errors should not occur in any case.

Is that an Acked-by?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html