Re: [PATCH 2/2] pinctrl: qcom: General Purpose clocks for apq8064

[Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>]

On Thu 10 Aug 23:55 PDT 2017, Vinay Simha BN wrote:

> Add support for general purpose (GP) clocks
> for apq8064
> 
> Signed-off-by: Vinay Simha BN <simhavcs@xxxxxxxxx>
> 
> ---
> v1:
> * only gp_clk_1b tested in nexus7 anx7808 slimport.
> ---
>  drivers/pinctrl/qcom/pinctrl-apq8064.c | 37 ++++++++++++++++++++++++++++------
>  1 file changed, 31 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-apq8064.c b/drivers/pinctrl/qcom/pinctrl-apq8064.c
[..]
> @@ -453,6 +477,7 @@ static const struct msm_function apq8064_functions[] = {
>  	FUNCTION(codec_mic_i2s),
>  	FUNCTION(codec_spkr_i2s),
>  	FUNCTION(gpio),
> +	FUNCTION(gp_clk_1b),

You missed the others variants here.

Other than that this looks good. So please add the other 5 functions and
you can resend this with my Acked-by.

PS. For small incremental patches like this, feel free to send the DT
binding updates in the same patch as the driver changes.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html