RE: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux property

["A.s. Dong" <aisheng.dong@xxxxxxx>]

Hi Shawn,

> -----Original Message-----
> From: Dong Aisheng [mailto:aisheng.dong@xxxxxxx]
> Sent: Wednesday, June 21, 2017 8:00 PM
> To: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linus.walleij@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; stefan@xxxxxxxx; Jacky Bai; Andy Duan;
> kernel@xxxxxxxxxxxxxx; A.s. Dong
> Subject: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux
> property
> 
> The generic pinmux property seems to be more suitable for IMX.
> So we change to use 'pinmux' instead of 'pins'.
> 
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Bai Ping <ping.bai@xxxxxxx>
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> 

Would you help review this minor change?

I will collect your ACKs and resent based on 4.13 RC1.

Regards
Dong Aisheng

> ---
> ChangeLog:
>  * new patch
> ---
>  drivers/pinctrl/freescale/pinctrl-imx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c
> b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 72aca75..fc1ba3c 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -563,14 +563,14 @@ static int imx_pinctrl_parse_groups(struct
> device_node *np,
>  	 * do sanity check and calculate pins number
>  	 *
>  	 * First try legacy 'fsl,pins' property, then fall back to the
> -	 * generic 'pins'.
> +	 * generic 'pinmux'.
>  	 *
> -	 * Note: for generic 'pins' case, there's no CONFIG part in
> +	 * Note: for generic 'pinmux' case, there's no CONFIG part in
>  	 * the binding format.
>  	 */
>  	list = of_get_property(np, "fsl,pins", &size);
>  	if (!list) {
> -		list = of_get_property(np, "pins", &size);
> +		list = of_get_property(np, "pinmux", &size);
>  		if (!list) {
>  			dev_err(info->dev,
>  				"no fsl,pins and pins property in node %s\n",
> --
> 2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html