On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote: > SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0), > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */ > + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */ > + SUNXI_FUNCTION_VARIANT(0x3, > + "pll_lock_dbg", > + PINCTRL_SUN8I_R40)), You have a number of lines where the wrapping is not consistent with the rest, such as this one, but also... > SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 20), > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > - SUNXI_FUNCTION(0x2, "i2c2")), /* SCK */ > + SUNXI_FUNCTION(0x2, "i2c2"), /* SCK */ > + SUNXI_FUNCTION_VARIANT(0x4, > + "pwm", /* PWM4 */ > + PINCTRL_SUN8I_R40)), ... this one for example. Please fix this. Looks good otherwise. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
