Re: [PATCH v2 3/3] pinctrl: qcom: add support to configure ipq40xx GPIO_PULL bits

[Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>]

On Sat 01 Jul 09:25 PDT 2017, Christian Lamparter wrote:

[..]
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h
> index 54fdd04ce9d5..71e97db5ba18 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.h
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.h
> @@ -115,6 +115,7 @@ struct msm_pinctrl_soc_data {
>  	const struct msm_pingroup *groups;
>  	unsigned ngroups;
>  	unsigned ngpios;
> +	bool pull_no_keeper;

This should be accompanied by a kerneldoc update in the lines of:
@pull_no_keeper:	The SoC does not support keeper bias

With something like that added:

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html