[bug report] pinctrl: add ZTE ZX pinctrl driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Shawn Guo,

This is a semi-automatic email about new static checker warnings.

The patch cbff0c4d27f4: "pinctrl: add ZTE ZX pinctrl driver support" 
from Apr 24, 2017, leads to the following Smatch complaint:

drivers/pinctrl/zte/pinctrl-zx.c:76 zx_set_mux()
	 warn: variable dereferenced before check 'data' (see line 67)

drivers/pinctrl/zte/pinctrl-zx.c
    66		struct zx_pin_data *data = pindesc->drv_data;
    67		struct zx_mux_desc *mux = data->muxes;
                                          ^^^^^^^^^^^
Dereference.

    68		u32 mask = (1 << data->width) - 1;
    69		u32 offset = data->offset;
    70		u32 bitpos = data->bitpos;
    71		struct function_desc *func;
    72		unsigned long flags;
    73		u32 val, mval;
    74	
    75		/* Skip reserved pin */
    76		if (!data)
                    ^^^^^
Too late.

    77			return -EINVAL;
    78	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux