Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thomas,

2017-06-30 6:33 GMT+09:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> The irq chip callbacks irq_request/release_resources() have absolutely no
> business with masking and unmasking the irq.
>
> The core code unmasks the interrupt after complete setup and masks it
> before invoking irq_release_resources().
>
> The unmask is actually harmful as it happens before the interrupt is
> completely initialized in __setup_irq().
>
> Remove it.

Good catch, thanks! (Note that the original patch of mine [1] did that
in .irq_startup()/.irq_shutdown(), which was for some reason changed
later, but I don't remember the exact story.)

[1] https://patchwork.kernel.org/patch/4466431/

Acked-by: Tomasz Figa <tomasz.figa@xxxxxxxxx>

Sylwester, Krzysztof, would you be able to do some basic test?

Best regards,
Tomasz

>
> Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
> @@ -205,8 +205,6 @@ static int exynos_irq_request_resources(
>
>         spin_unlock_irqrestore(&bank->slock, flags);
>
> -       exynos_irq_unmask(irqd);
> -
>         return 0;
>  }
>
> @@ -226,8 +224,6 @@ static void exynos_irq_release_resources
>         shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];
>         mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;
>
> -       exynos_irq_mask(irqd);
> -
>         spin_lock_irqsave(&bank->slock, flags);
>
>         con = readl(bank->eint_base + reg_con);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux