Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage

[Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>]

On 10/06/17 00:22, Ralph Sennhauser wrote:
> On Fri,  9 Jun 2017 12:09:17 +0200
> Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote:
> 
>> In some place in the driver regmap_update_bits was misused. Indeed the
>> last argument is not the value of the bit (or group of bits) itself
>> but the mask value inside the register.
>>
>> So when setting the bit N, then the value must be BIT(N) and not 1.
>>
>> CC: Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>
>> CC: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
>> ---
> 
> Hi Gregory,
> 
> Tested-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
> 
> Thanks for the prompt fix
> Ralph

Also works for me

Tested-by: Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html