Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>
>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>
>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I already sent a combined patch fixing these two deps earlier today,
> good that we are several at it :)

Hmm... issues like these are actually the reasons why the of_node member
of struct device does not depend on CONFIG_OF?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html