Re: [PATCH 01/10] gpio: mockup: fix direction values

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> The comment in linux/gpio/driver.h says:
>
>  @get_direction: returns direction for signal "offset", 0=out, 1=in
>
> We got those switched at some point. Fix the values.

Shouldn't it have a Fixes tag?


>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> ---
>  drivers/gpio/gpio-mockup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index c6dadac..c18d011 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -29,8 +29,8 @@
>  #define        GPIO_MOCKUP_MAX_GC      10
>
>  enum {
> -       DIR_IN = 0,
> -       DIR_OUT,
> +       DIR_OUT = 0,
> +       DIR_IN = 1,
>  };
>
>  /*
> --
> 2.9.3
>



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html