On Tue, May 23, 2017 at 10:37:27AM +0000, A.S. Dong wrote: > > > +#ifndef __DTS_IMX7ULP_PINFUNC_H > > > +#define __DTS_IMX7ULP_PINFUNC_H > > > + > > > +/* > > > + * The pin function ID is a tuple of > > > + * <mux_conf_reg input_reg mux_mode input_val> */ > > > + > > > +#define ULP1_PAD_PTC0__PTC0 > > > 0x0000 0x0000 0x1 0x0 > > > > > > For consistency with other SoCs, can we add MX7 to the define? E.g. > > MX7ULP1? > > > > ULP1 is another SoC name of IMX7ULP. > And there will be ULP0, ULPx in the future.. What is the external/formal SoC name for ULP0 and ULPx? > > It looks like not big issue, so I did not change it. It's an easy change to make things more obvious, so +1 on Stefan's opinion. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html