Hello, On Fri, 19 May 2017 17:27:36 +0100, Russell King - ARM Linux wrote: > Hmm, in fact, mvebu->offset always appears to be zero in this driver, > so I think the changes that add this member are entirely rendundant to > the function of this patch. >From PATCH 6/6: + offset = <0x1040>; + offset = <0x100>; + offset = <0x140>; So, no mvchip->offset is not always 0. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html