Hi Geert, Thank you for the patches. On Tuesday 09 May 2017 16:11:53 Geert Uytterhoeven wrote: > Hi all, > > Magnus reported that on sh7722/Migo-R, pinctrl registration fails with: > > sh-pfc pfc-sh7722: pin 0 already registered > sh-pfc pfc-sh7722: error during pin registration > sh-pfc pfc-sh7722: could not register: -22 > sh-pfc: probe of pfc-sh7722 failed with error -22 > > pinmux_pins[] is initialized through PINMUX_GPIO(), using designated > array initializers, where the GPIO_* enums serve as indices. > Apparently GPIO_PTQ7 was defined in the enum, but never used. > If enum values are defined, but never used, pinmux_pins[] contains > (zero-filled) holes. Hence such entries are treated as pin zero, which > was registered before, and initialization fails. > > I can't see how this ever worked, as at the time of commit f5e25ae52feff2dc > ("sh-pfc: Add sh7722 pinmux support"), pinmux_gpios[] in > drivers/pinctrl/sh-pfc/pfc-sh7722.c already had the hole, and > drivers/pinctrl/core.c already had the check. > > Some scripting revealed a few more broken drivers: > - sh7757 has four holes, due to nonexistent GPIO_PT[JLNQ]7_RESV. > - sh7264 and sh7269 define GPIO_PH[0-7], but don't use it with > PINMUX_GPIO(). > > Patch 1 fixes the issue on sh7722, and was tested. > Patches 3-4 should fix the issue on the other 3 SoCs, but was untested due > to lack of hardware. This all looks good to me, even if I can't test or verify patches 2/4 to 4/4 as I don't have access to the hardware or datasheet either. Given that they're untested I wouldn't fake the error message in the commit log though, but just refer to the problem noticed on sh7722. Apart from that, for the whole series, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Thanks for your comments! > > Geert Uytterhoeven (4): > sh: sh7722: Remove nonexistent GPIO_PTQ7 to fix pinctrl registration > [RFC] sh: sh7757: Remove nonexistent GPIO_PT[JLNQ]7_RESV to fix > pinctrl registration > sh: sh7264: Remove nonexistent GPIO_PH[0-7] to fix pinctrl > registration > [RFC] sh: sh7269: Remove nonexistent GPIO_PH[0-7] to fix pinctrl > registration > > arch/sh/include/cpu-sh2a/cpu/sh7264.h | 4 +--- > arch/sh/include/cpu-sh2a/cpu/sh7269.h | 4 +--- > arch/sh/include/cpu-sh4/cpu/sh7722.h | 2 +- > arch/sh/include/cpu-sh4/cpu/sh7757.h | 8 ++++---- > 4 files changed, 7 insertions(+), 11 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html