RE: [PATCH -next] pinctrl: artpec6: Fix return value check in artpec6_pmx_probe()

["weiyongjun (A)" <weiyongjun1@xxxxxxxxxx>]

> -----Original Message-----
> From: Jesper Nilsson [mailto:jesper.nilsson@xxxxxxxx]
> Sent: Tuesday, April 25, 2017 4:31 PM
> To: Wei Yongjun <weiyj.lk@xxxxxxxxx>
> Cc: Jesper Nilsson <jespern@xxxxxxxx>; Lars Persson <larper@xxxxxxxx>;
> Niklas Cassel <niklass@xxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>;
> weiyongjun (A) <weiyongjun1@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxx;
> linux-gpio@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH -next] pinctrl: artpec6: Fix return value check in
> artpec6_pmx_probe()
> 
> On Tue, Apr 25, 2017 at 03:29:45AM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> >
> > In case of error, the function pinctrl_register() returns
> > NULL not ERR_PTR(). The IS_ERR() test in the return value
> > check should be replaced with NULL test.
> 
> Uh, the comment above reads as the exact opposite
> of what the patch does. Your point is valid though,
> but the comment needs rephrasing.
> 

Oh, sorry, I will send the v2 patch with comment fixed soon.
Thanks.

Wei Yongjun
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html