RE: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: add missing DVC_MUTE signal

[Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>]

Hello Geert,

> From: geert.uytterhoeven@xxxxxxxxx
> [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert Uytterhoeven
> Sent: 30 March 2017 10:11
> 
> Hi Chris,
> 
> On Thu, Mar 30, 2017 at 11:00 AM, Geert Uytterhoeven <geert@linux-
> m68k.org> wrote:
> > On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson
> > <Chris.Paterson2@xxxxxxxxxxx> wrote:
> >>> From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx
> >>> [mailto:linux-renesas-soc- owner@xxxxxxxxxxxxxxx] On Behalf Of
> >>> Sergei Shtylyov
> >>> Sent: 29 March 2017 19:37
> >>>
> >>> The R8A7791 PFC driver  was apparently based on the preliminary
> >>> revisions of the user's  manual, which  omitted the DVC_MUTE signal
> >>> altogether in the PFC section. The modern manual has the signal
> >>> described,  so just add the necassary data to the driver...
> >>>
> >>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >>
> >> Should this patch also CC stable? (Patch 1/2 does)
> >
> > No need to spam stable with all these patches and reviews.
> > If it has a Fixes-tag, the stable team will pick it up anyway. After
> > it has ended up upstream.

Okay.

> 
> And in this case, there's not really a need to backport it to stable, as there
> cannot be any users due to lack of pins using these definitions.

Whereas the first patch in the series fixes a problem that *is* currently seen by users, so will need backporting. Makes sense now, thanks!

Kind regards, Chris

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f