Re: [PATCH] pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Mar 29, 2017 at 3:19 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Wed, Mar 29, 2017 at 02:58:19PM +0200, Linus Walleij wrote:
>> On Wed, Mar 29, 2017 at 11:59 AM, Mika Westerberg
>> > +       chip->irq_need_valid_mask = need_valid_mask;
>>
>> Isn't the right solution to translate this back to the offset from the "Linux
>> IRQ" and use that offset? This quirk seems pretty violent.
>
> So based on DMI strings instead of doing this, just correct the offset
> and be done with it? Works for me.

Yeah I imagine? We just fix up the Linux magic numbers to the hardware
magic numbers.

This is what a poor soul trying to port this chromebook to use BSD or
Windows will have to do anyway, so I don't see why we should be
different.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html