On Wed, Mar 22, 2017 at 3:11 PM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > + return (reg_val & (1u << (off % BANK_SZ))) ? GPIOF_DIR_IN : GPIOF_DIR_OUT; The GPIOF_DIR_IN/GPIOF_DIR_OUT are part of the consumer API and should not be used inside drivers. I've fixed it up to 1/0 when applying. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Thu, 23 Mar 2017 10:38:42 +0100
- In-reply-to: <20170322141113.34396-1-andriy.shevchenko@linux.intel.com>
- References: <20170322141113.34396-1-andriy.shevchenko@linux.intel.com>
- References:
- [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
- From: Andy Shevchenko
- [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
- Prev by Date: Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls
- Next by Date: Re: [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
- Previous by thread: Re: [PATCH v2 2/3] gpio: pca953x: Sort headers alphabetically
- Next by thread: Re: [PATCH v2 1/3] gpio: pca953x: Introduce a long awaited ->get_direction()
- Index(es):
 |