Re: [PATCH v2] gpio: acpi: Call enable_irq_wake for _IAE GpioInts with Wake set

["Rafael J. Wysocki" <rafael@xxxxxxxxxx>]

On Tue, Mar 21, 2017 at 1:30 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Mon, 2017-03-20 at 18:32 +0100, Hans de Goede wrote:
>> On Bay Trail / Cherry Trail systems with a LID switch, the LID switch
>> is
>> often connect to a gpioint handled by an _IAE event handler.
>> Before this commit such systems would not wake up when opening the
>> lid,
>> requiring the powerbutton to be pressed after opening the lid to
>> wakeup.
>>
>> Note that Bay Trail / Cherry Trail systems use suspend-to-idle, so
>> the interrupts are generated anyway on those lines on lid switch
>> changes,
>> but they are treated by the IRQ subsystem as spurious while suspended
>> if
>> not marked as wakeup IRQs.
>>
>> This commit calls enable_irq_wake() for _IAE GpioInts with a valid
>> event handler which have their Wake flag set. This fixes such systems
>> not waking up when opening the lid.
>>
>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>>
>
>> +     bool irq_wake_enabled;
>>
>
>> +             if (event->irq_wake_enabled)
>>
>
> Same (new) comment as in v1.

Why not just check for agpio->wake_capable == ACPI_WAKE_CAPABLE
instead as I said?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html