Hello, On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote: > On 1/25/2017 9:09 PM, Jacopo Mondi wrote: > > Add TxD and RxD pin configuration for SCIF2 serial communication > > interface on r7s72100 Genmai board. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > --- > > > > arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts > > b/arch/arm/boot/dts/r7s72100-genmai.dts index 118a8e2..ea649c7 100644 > > --- a/arch/arm/boot/dts/r7s72100-genmai.dts > > +++ b/arch/arm/boot/dts/r7s72100-genmai.dts > > [...] > > > @@ -34,6 +35,18 @@ > > #address-cells = <1>; > > #size-cells = <1>; > > }; > > + That's not needed. > > +}; > > + > > +&pinctrl { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&scif2_pins>; > > + > > + scif2_pins: serial2 { > > + /* P3_0 as TxD2; P3_2 as RxD2 */ > > + renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>, > > The comma should be after the vendor prefix ("renesas"). And the "-rz" suffix isn't needed, "renesas,pins" will do. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html