On Thu, Jan 19, 2017 at 11:23 PM, Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > From: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx> > > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which > can be controlled using gpio interface. > > Add the gpio specific code. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx> Patch applied. I think maybe we can simplify the patch even more using select GPIO_GENERIC and just specify the different registers to bgpio_init(). But that can be done as a separate improvement patch, this definately looks fine. Maybe you also want something like: default SERIAL_8250_EXAR so that the module is by default added as "y" or "m" depending on what is selected for the parent device? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html