On Fri, Jan 13, 2017 at 2:20 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redudant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Fixed up speling & commit topic and applied with
Nishanth's ACK!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Wed, 18 Jan 2017 10:24:52 +0100
- In-reply-to: <20170113132039.19830-1-colin.king@canonical.com>
- References: <20170113132039.19830-1-colin.king@canonical.com>
- References:
- [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
- From: Colin King
- [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
- Prev by Date: Re: [PATCH RFC 5/5] pinctrl: mvebu: add simple regmap based pinctrl implementation
- Next by Date: Re: [PATCH v2 3/6] pinctrl: Add a possibility to configure pins from a gpiolib based drivers
- Previous by thread: Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
- Next by thread: [git pull] pinctrl: sh-pfc: Updates for v4.11
- Index(es):
 |