Re: [PATCH v2 4/7] arm: dts: r7s72100-genmai: SCIF2 PINCTRL configuration

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Jacopo,

On Wed, Jan 11, 2017 at 10:57 AM, Jacopo Mondi
<jacopo+renesas@xxxxxxxxxx> wrote:
> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>
> Configure the r7s72100 PINCTRL hardware and select pin function
> for the SCIF2 serial console.
>
> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/r7s72100-genmai.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
> index 118a8e2..8d8fcc7 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai.dts
> @@ -59,6 +59,16 @@
>         };
>  };
>
> +&pfc {
> +       pinctrl-0 = <&scif2_pins>;
> +       pinctrl-names = "default";
> +
> +       scif2_pins: serial2 {
> +               renesas,groups = "scif2_txd_p3_0", "scif2_rxd_p3_2";
> +               renesas,function = "scif2";

Please drop the "renesas," prefixes
The "functions", "groups", and "pins" property names have been standardized
since the initial r7s72100 support was written.

Obviously this comment applies to all relevant patches.

> +       };
> +};
> +
>  &scif2 {
>         status = "okay";
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html