Re: [PATCH v2 1/1] pinctrl: baytrail: Rectify debounce support

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Tue, Jan 10, 2017 at 04:38:52PM +0200, Andy Shevchenko wrote:
> The commit 658b476c742f ("pinctrl: baytrail: Add debounce configuration")
> implements debounce for Baytrail pin control, but seems wasn't tested properly.
> 
> The register which keeps debounce value is separated from the configuration
> one. Writing wrong values to the latter will guarantee wrong behaviour of the
> driver and even might break something physically.
> 
> Besides above there is missed case how to disable it, which is actually done
> through the bit in configuration register.
> 
> Rectify implementation here by using proper register for debounce value.
> 
> Fixes: 658b476c742f ("pinctrl: baytrail: Add debounce configuration")
> Cc: Cristina Ciocan <cristina.ciocan@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Now it looks perfect, thanks!

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html