Re: [PATCH v1 1/1] pinctrl: intel: Set pin direction properly

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, 2017-01-09 at 16:29 +0200, Jarkko Nikula wrote:
> On 01/02/2017 02:07 PM, Andy Shevchenko wrote:
> > There are two bits in the PADCFG0 register to configure direction,
> > one per
> > TX/RX buffers.
> > 
> > For now we wrongly assume that the GPIO is always requested before
> > it is being
> > used, which is not true when the GPIO is used through irqchip. In
> > this case the
> > GPIO is never requested and we never enable RX buffer for it.
> > 
> > Fix this by setting both bits accordingly.
> > 
> > Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > 


> > @@ -392,18 +407,11 @@ static int intel_gpio_set_direction(struct
> > pinctrl_dev *pctldev,
> 
> I'm testing this on top of v4.10.0-rc3 and I don't see changes in 
> PADCFG0 after this patch. I guess reason is that the code doesn't go 
> through above functions for the pin that is used through irqchip but 
> through intel_gpio_irq_type().
> 
> Am I missing some another patch or should your patch add 
> __intel_gpio_set_direction() also there?

The problem you reported about apparently discovers two places to be
fixed. This is part 1. Part 2 will be send with GPIO ACPI clean up / bug
fix series later.

The rest of patches is available on my public tree:
https://bitbucket.org/andy-shev/linux/branch/topic%2Fuart%2frpm

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html