Re: [PATCH v1 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, 2017-01-04 at 14:52 +0200, Mika Westerberg wrote:
> On Tue, Jan 03, 2017 at 07:01:19PM +0200, Andy Shevchenko wrote:
> > Make fwnode_get_named_gpiod() consistent with the rest of
> > gpiod_get() like API,
> > i.e. configure GPIO pin immediately after request.
> > 
> > Besides obvious clean up it will help to configure pins based on
> > firmware
> > provided resources.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpio/devres.c                     |  9 +++++++--
> >  drivers/gpio/gpiolib.c                    | 20 ++++++++++++++++----
> >  drivers/input/keyboard/gpio_keys.c        |  9 +--------
> >  drivers/input/keyboard/gpio_keys_polled.c | 11 ++---------
> >  drivers/leds/leds-gpio.c                  |  2 +-
> >  drivers/video/fbdev/amba-clcd-nomadik.c   | 15 +++++----------
> >  include/linux/gpio/consumer.h             | 19 +++++++++++++------
> >  7 files changed, 45 insertions(+), 40 deletions(-)
> > 
> > diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
> > index 54da61112752..3da9c39fed04 100644
> > --- a/drivers/gpio/devres.c
> > +++ b/drivers/gpio/devres.c
> > @@ -129,13 +129,18 @@ EXPORT_SYMBOL(devm_gpiod_get_index);
> >   * @dev:	GPIO consumer
> >   * @con_id:	function within the GPIO consumer
> >   * @child:	firmware node (child of @dev)
> > + * @flags:	GPIO initialization flags
> 
> Please call this 'dflags' as it is called elsewhere as well.

Elsewhere in this file it's called 'flags'. I would stick with that
(btw, my internal first version used to have 'dflags').

> 
> Otherwise looks reasonable to me.
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html