Re: [PATCH] pinctrl/amd: Set the level based on ACPI tables

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Dec 8, 2016 at 1:01 PM, Shyam Sundar S K <ssundark@xxxxxxx> wrote:

> In the function amd_gpio_irq_set_type, read the values from
> the ACPI table to set the level and drop the settings passed
> by the client.
>
> Reviewed-by: Pankaj Sen <Pankaj.Sen@xxxxxxx>
> Reviewed-by: Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@xxxxxxx>
> Reviewed-by: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@xxxxxxx>
> Signed-off-by: Shyam-sundar S-k <Shyam-sundar.S-k@xxxxxxx>

Patch applied. The code makes a lot more sense now, too.

> -       /*
> -        * When level_trig is set EDGE and active_level is set HIGH in BIOS
> -        * default settings, ignore incoming settings from client and use
> -        * BIOS settings to configure GPIO register.
> +       /* Ignore the settings coming from the client and
> +        * read the values from the ACPI tables
> +        * while setting the trigger type

In my book you do the exact opposite: the client/consumer is the device
making use of this IRQ, and that defines what trigger to set.

Before this, you let the hardware power-on defaults define the trigger, which
was probably not such a good idea.

But it's just a comment so I don't care much.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html