[bug report] pinctrl: sunxi: Deal with configless pins

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Maxime Ripard,

The patch e11dee2e98f8: "pinctrl: sunxi: Deal with configless pins"
from Oct 20, 2016, leads to the following static checker warning:

	drivers/pinctrl/sunxi/pinctrl-sunxi.c:397 sunxi_pctrl_dt_node_to_map()
	warn: variable dereferenced before check 'map' (see line 323)

drivers/pinctrl/sunxi/pinctrl-sunxi.c
   394          *num_maps = i;
   395  
   396          /*
   397           * We know have the number of maps we need, we can resize our
   398           * map array
   399           */
   400          *map = krealloc(*map, i * sizeof(struct pinctrl_map), GFP_KERNEL);
   401          if (!map)

This should obviously be "if (*map) " here.

   402                  return -ENOMEM;
   403  
   404          return 0;
   405  
   406  err_free_map:
   407          kfree(map);

I would send a patch, but I wasn't sure about this.  Should this be
kfree(*map);?  I don't have my cross function DB built for ARM so I
don't know how this is called...  Maybe set *map to NULL as well before
returning?

   408          return ret;
   409  }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html