Re: [PATCH] gpio: em: depnd on ARCH_SHMOBILE

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Nov 7, 2016 at 10:55 AM, Peter Robinson <pbrobinson@xxxxxxxxx> wrote:
> On Mon, Nov 7, 2016 at 9:01 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Sun, Nov 6, 2016 at 7:53 PM, Peter Robinson <pbrobinson@xxxxxxxxx> wrote:
>>
>>> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>>>
>>> Signed-off-by: Peter Robinson <pbrobinson@xxxxxxxxx>
>>
>> What about also enabling COMPILE_TEST?
>
> Happy to, never really know the rule of thumb on COMPILE_TEST, the
> decision to enable it always seems somewhat arbitrary (almost like it
> should be an option for all drivers when run in that mode as opposed
> to explicitly adding an option).

I think in these patches ask:

- Did it compile a lot before the change and get a lot of coverage?

- Does it compile less after this change?

- Then add COMPILE_TEST so we can get that coverage
  back when needed for test.

I do understand the point of not pushing a lot of options and pointless
compilation and modules in the face of everyone in the world, just that
the compile farms still need to churn these drivers.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html