On 8/11/2016 16:30, Linus Walleij wrote:
On Tue, Nov 8, 2016 at 7:00 AM, Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote:
gpiod_set_array_value_complex does not clear the bits field.
Therefore when the drivers set_multiple funciton is called bits outside
the mask are undefined and can be either set or not. So bank_val needs
to be masked with bank_mask before or with the reg_val cache.
Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>
Patch applied for fixes. Should it also be tagged for stable?
Is there a commit this fixes that we can set as Fixes:?
It looks like it was broken in my original implementation of the set_multiple call.
fixes commit: b4818afeacbd81821f89a89951471cffcb6a65e0
I guess it should probably go into stable.
--
Regards
Phil Reid
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
