Re: [PATCH] gpio: mxc: fix build error introduced by pin_ranges

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Nov 1, 2016 at 8:03 AM, Deepak Das <deepak_das@xxxxxxxxxx> wrote:

> 'commit 964a7e51240df ("gpio: mxc: Shift
> generic request/free after gpiochip registration")'
> introduced a build error because pin_ranges now moved to
> struct gpio_device.
>
> This commit fixes this build error by dereferencing gpio_device
> inside struct gpio_chip for pin_ranges.
>
> Signed-off-by: Deepak Das <deepak_das@xxxxxxxxxx>

NAK and I backed out the patch causing this.

> +#include "gpiolib.h"

Nothing should dereference the gpiolib internals, that is pretty clear
from the way it is split out of the public headers.

We need to go back to the first patch and look things over,

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html