Re: [PATCH 1/2] pinctrl: single: Drop custom names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tony Lindgren <tony@xxxxxxxxxxx> [161025 09:10]:
> We no longer need to allocate custom names as those are dynamically
> generated in pinctrl_register_one_pin() if no name is passed to
> pinctrl_register_pins().
...

> @@ -354,13 +337,16 @@ static void pcs_pin_dbg_show(struct pinctrl_dev *pctldev,
>  {
>  	struct pcs_device *pcs;
>  	unsigned val, mux_bytes;
> +	unsigned long offset;
>  
>  	pcs = pinctrl_dev_get_drvdata(pctldev);
>  
>  	mux_bytes = pcs->width / BITS_PER_BYTE;
> -	val = pcs->read(pcs->base + pin * mux_bytes);
> +	offset = pin * mux_bytes;
> +	val = pcs->read(pcs->base + offset);
>  
> -	seq_printf(s, "%08x %s " , val, DRIVER_NAME);
> +	seq_printf(s, "%lx %08x %s ", pcs->res->start + offset, val,
> +		   DRIVER_NAME);
>  }

This should use %zx instead of %lx to avoid build warnings on 64-bit
systems as reported by kbuild test robot.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux