Re: [PATCH] pinctrl: imx: remove unused gpoup_index field

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Oct 20, 2016 at 10:17 PM, Stefan Agner <stefan@xxxxxxxx> wrote:
> Hi Vladimir,
>
> On 2016-10-18 15:47, Vladimir Zapolskiy wrote:
>> The group_index field of struct imx_pinctrl_soc_info does not serve
>> any particular purpose and its usage can be safely replaced by
>> a preexisting local variable.
>>
>> Also Stefan Agner reports that the usage of the group_index field
>> without reinitialization may lead to an oops on a repeated driver
>> probe, this is found with DEBUG_TEST_DRIVER_REMOVE option enabled.
>
> The change is a good idea, and it works for flat pinctrl configurations.
> However it does not work when there are multiple sub nodes (or function
> nodes).
>
> I am all in for the new flat format, but we should at least make sure
> that all device trees are flat or have only one subnode. If that is the
> case, we also should add a warning... All that makes me wonder if it is
> worth the effort...
>
> Also added Robin Gon which added the field not long ago.

I think I need Shawn's or Sascha's input here before applying.

My opinion is certainly not very useful, all of you know
these systems better than me.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html