Re: [PATCH 1/2] pinctrl: sunxi: Add support for interrupt debouncing

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Oct 19, 2016 at 11:15 AM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:

> The pin controller found in the Allwinner SoCs has support for interrupts
> debouncing.
>
> However, this is not done per-pin, preventing us from using the generic
> pinconf binding for that,

How typical.

> but per irq bank, which, depending on the SoC,
> ranges from one to five.
>
> Introduce a device-wide property to deal with this using a nanosecond
> resolution.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
(...)
> +Note: For backward compatibility reasons, the hosc and losc clocks are
> +only required if you need to use the optional
> +allwinner,debounce-time-ns property. Any new device tree should set them.
> +
> +Optional properties:
> +  - allwinner,debounce-time-ns: Array of debouncing periods in
> +    nanoseconds. One period per irq bank found in the controller

Do you really *need* to specify this with nanosecond resolution?

Else I would suggest to use microsecond resolution and just use
the generic binding (input-debounce) but on the device node instead
of the specific handler.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html