Hi Rob, > On Oct 10, 2016, at 23:10 , Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Oct 07, 2016 at 06:19:32PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev <gvlaev@xxxxxxxxxxx> >> >> Add DT bindings document for the PTXPMB extended CPLD device. >> >> Signed-off-by: Georgi Vlaev <gvlaev@xxxxxxxxxxx> >> [Ported from Juniper kernel] >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx> >> --- >> .../bindings/mfd/jnx-ptxpmb-ext-cpld.txt | 35 ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/jnx-ptxpmb-ext-cpld.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/jnx-ptxpmb-ext-cpld.txt b/Documentation/devicetree/bindings/mfd/jnx-ptxpmb-ext-cpld.txt >> new file mode 100644 >> index 0000000..098a548a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/jnx-ptxpmb-ext-cpld.txt >> @@ -0,0 +1,35 @@ >> +* Device tree bindings for Juniper's PTXPMB Extended CPLD FPGA MFD driver >> + >> +The device supports a gpio block which is described in the >> +jnx-gpio-ptxpmb-ext-cpld document. >> + >> +Required properties: >> + >> +- compatible: "jnx,ptxpmb-ext-cpld" >> + >> +- reg: contains offset/length value for device state control >> + registers space. >> + >> +Optional properties: >> + >> +- interrupts: The interrupt line(s) the /IRQ signal(s) for the device is >> + connected to. >> + >> +- interrupt-parent: The parent interrupt controller. >> + >> +Example: >> + >> +ext-cpld@1,0 { >> + compatible = "jnx,ptxpmb-ext-cpld"; >> + reg = <0x1 0 0x1000>; > > What's the bus type here? Unit address is probably wrong. > localbus on a gpmc memory controller. >> + interrupt-parent = <&mpic>; >> + interrupts = <7 2>, <8 2>; >> + >> + gpio_ext_cpld: cpld-ext-gpio { >> + compatible = "jnx,gpio-ptxpmb-ext-cpld"; >> + #gpio-cells = <2>; >> + #interrupt-cells = <2>; >> + gpio-controller; >> + interrupt-controller; >> + }; >> +}; >> -- >> 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html