Re: [bug report] pinctrl: berlin: Don't leak memory if krealloc() fails

[Johannes Thumshirn <jthumshirn@xxxxxxx>]

On Wed, Oct 12, 2016 at 11:45:27AM +0300, Dan Carpenter wrote:
> On Wed, Oct 12, 2016 at 10:30:02AM +0200, Johannes Thumshirn wrote:
> > Oh I see. Damn, missed the devm_kzalloc(). But shouldn't we avoid krealloc()
> > on devm_kzalloc() in general? krealloc() calls kfree() if the reallocation
> > succeeded and this will break the devres tracking, wouldn't it?
> 
> Good point.  I will update my test to check for that.

Well the initial problem still stands, how do we fix the possible double
free? I think I could "just" change the devm_kzalloc() to kzalloc() (and
introduce cleanups) but I'm not sure this is a good solution. The whoule point
of these devm stuff is to apply a safety net, isn't it?

Linus how shall we proceed? Reverting the patch keeps the double-free (IMHO
but I'm not 100% sure how this devres tracking works if we do a realloc on the
pointer) and reintroduces the memory leak.

Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html