Re: [patch] gpio: stmpe: || vs && typo

[Patrice Chotard <patrice.chotard@xxxxxx>]

Hi Dan

On 10/12/2016 08:25 AM, Dan Carpenter wrote:
> && was obviously intended here.
> 
> Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
> index e7d422a..5b00427 100644
> --- a/drivers/gpio/gpio-stmpe.c
> +++ b/drivers/gpio/gpio-stmpe.c
> @@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
>  		 * 801/1801/1600, bits are cleared when read.
>  		 * Edge detect register is not present on 801/1600/1801
>  		 */
> -		if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
> +		if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
>  		    stmpe->partnum != STMPE1801) {
>  			stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
>  			stmpe_reg_write(stmpe,
> 

Well spotted ;-)

Acked-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html