Re: [PATCH 2/3] gpio: acpi: separation of concerns

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Oct 3, 2016 at 12:24 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Mon, Oct 03, 2016 at 11:02:39AM +0200, Linus Walleij wrote:
>> The generic GPIO library directly implement code for acpi_find_gpio()
>> which is only used with CONFIG_ACPI. This was probably done because
>> OF did the same thing, but I removed that so remove this too.
>
> Yes, it was originally copied from the DT implementation.
>
>> Rename the internal acpi_find_gpio() in gpiolib-acpi.c to
>> acpi_populate_gpio_lookup() which seems to be more appropriate anyway
>> so as to avoid a namespace clash with the same function.
>>
>> Make the stub return -ENOENT rather than -ENOSYS (as that is for
>> syscalls!).
>
> -ENXIO?

Sorry for not writing all that I think.

The code works like such that if -ENOENT is returned, the core
will proceed to check for presence of boardfile-type hardcoded
descriptor tables. Which might be relevant.

(The mechanism should be used as fallback also when no
desc is found in the ACPI lookup, actually.)

>> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> Regardless of that,
>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html