Re: [PATCH] ARM: omap2: fix missing include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Linus Walleij <linus.walleij@xxxxxxxxxx> [160923 05:40]:
> commit d47529b2e9fe
> "gpio: don't include module.h in shared driver header"
> removed <linux/module.h> from the <linux/gpio/driver.h> header.
> 
> It seems arch/arm/mach-omap2/board-rx51-peripherals.c
> is using __initdata_or_module from <linux/module.h> through
> <linux/gpio.h> to <linux/gpio/driver.h>, so break this dependency
> so that we get a clean compile.
> 
> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Fixes: d47529b2e9fe ("gpio: don't include module.h in shared driver header")
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> Tony: please ACK this if it's OK so I can merge it in front of
> the offending patch.

This file is gone in Linux next but if you need it:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>

Sorry the removal got postponed from v4.8 to v4.9. Note that
it will produce a trivial merge conflict.

> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index a5ab712c1a59..6d3af43ae3e4 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -29,6 +29,7 @@
>  #include <linux/power/isp1704_charger.h>
>  #include <linux/platform_data/spi-omap2-mcspi.h>
>  #include <linux/platform_data/mtd-onenand-omap2.h>
> +#include <linux/module.h>
>  
>  #include <plat/dmtimer.h>
>  
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux