On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > Most shared headers in include/linux don't need to know what the > internals of a struct module are; all they care about is that it > is a struct and hence they may require a pointer to one. > > The advantage in this is that module.h is including a lot of stuff > itself, and an otherwise empty C file that just contains module.h > will result in ~750kB from CPP (compared to say 12kB from init.h) > > So we have approximately 50 instances of "struct module;" in the > various include/linux headers already that help us keep module.h > out of other headers; here we do the same for gpio. > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx> > Cc: linux-gpio@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Probably my mistake. Thanks for tidying this up so nicely! Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html