Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage

[Arnd Bergmann <arnd@xxxxxxxx>]

On Tuesday, September 13, 2016 12:04:00 PM CEST Phil Reid wrote:
> On 12/09/2016 21:40, Linus Walleij wrote:
> > On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> >
> >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >>
> >> ret is not initialized so it contains garbage.  Ensure garbage
> >> is not returned in the case that pdata && pdata->teardown is false
> >> by initializing ret to 0.
> >>
> >> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > Patch applied.
> G'day Linus,
> 
> 
> I believe this does the same as Arnd Bergmanns patch from 26 Aug.
> [PATCH 1/5] gpio: pca954x: fix undefined error code from remove
> 
> IMO Colin's is the cleaner solution.
> Arnd's could be removed.
> 

Please try to avoid adding initializations in the local variable
declaration, they just hide otherwise useful warnings when
you get a function that actually does something incorrect
in some code paths.

See also https://rusty.ozlabs.org/?p=232

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html