On Mon, Sep 5, 2016 at 4:31 PM, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> wrote: > There are multiple places in the driver code where a > switch (chip->chip_type) is used to determine the proper register > offset. > > Unduplicate the code by adding a simple structure holding the possible > offsets that differ between the pca953x and pca957x chip families and > use it to avoid the checks. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> This doesn't apply beacuse of other changes made to the driver by Phil Reid et al. Can you please rebase your work on top of my gpio "devel" branch: https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel and at the same time fix Geert's reported const thing? I'm overall happy with the patch series and would like to apply also patches 2-5 for v4.9 soon. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html