Re: [PATCH 1/3] pinctrl: export pin_request to support parent pin

[Jun Nie <jun.nie@xxxxxxxxxx>]

2016-09-06 21:55 GMT+08:00 Linus Walleij <linus.walleij@xxxxxxxxxx>:
> On Fri, Aug 26, 2016 at 2:19 PM, Jun Nie <jun.nie@xxxxxxxxxx> wrote:
>
>> Some pin functions may be controlled in 2nd level multiplex.
>> We need configure 1st level multiplex when request such
>> functions. Export pin_request functionality so that parent
>> can be configured automatically with calling it in
>> pinmux_ops->request().
>>
>> Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx>
>
> This looks weird as 1/3, please put the DT bindings first in the
> series.

I thought 1/3 patch does not relate to ZTE driver directly, so I put as the
2nd patch. Will move it to the very first one as you point out.

>
> We first need to agree on how to represent this before we start
> hacking around in the core to support different shortcuts.
>
> This patch just makes me nervous, but maybe I can be convinced
> otherwise if we get some details on how the hardware works and why
> this is necessary.

Hardware has two register regions to control pinmux, one is for normal
function configuration and the other one is for always on subsystem(AON).
Some pins are controlled by both normal register and AON register. AON
register is the first level control for pinmux. If we need any
function in normal
register configuration, we need configure related AON pinmux register as
non-AON function first. Then we configure normal pinmux register to get the
pin function we want.

>
> Yours,
> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html