Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx> writes: > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: >> Maybe this one would deserve a doxygen comment ? > > Does this solve it? Oh yes, that's very nice, especially the "1 = in" for which I have always a doubt. Reviewed-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> I hope to have an "attempt" to test all your series on the lubbock board in the next days. The "attempt" part is because last time I checked pcmcia support was broken on lubbock (ie. CONFIG_PCMCIA_SA1111 activated implies an Oops), and I don't remember having repaired it (and it's disabled on my test farm which is a sign I was not very confident about this part). If you happen to have somewhere a branch I can pull, with all your series (at least "[RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)" and "[PATCH 0/8] SA11x0/PXA remainder & cleanups"), that would spare me the multiple git-am to make the test(s). Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html