Re[2]: [PATCH 07/13] pinctrl: add a pincontrol driver for BCM6358

[Alexander Shiyan <shc_work@xxxxxxx>]

>Вторник, 23 августа 2016, 12:18 +03:00 от Linus Walleij <linus.walleij@xxxxxxxxxx>:
>
>On Mon, Aug 22, 2016 at 3:57 PM, Jonas Gorski < jonas.gorski@xxxxxxxxx > wrote:
>> On 22 August 2016 at 15:21, Linus Walleij < linus.walleij@xxxxxxxxxx > wrote:
>
>>>> +       else
>>>> +               mode = syscon_regmap_lookup_by_pdevname("syscon.fffe0098");
>>>
>>> That looks very very fragile.
>>
>> For !OF I need to use the pdevname, so I need to "guess" the right
>> one, and using the scheme of "syscon.<address>" seemed to be the one
>> most likely not conflicting with anything else.
>
>OK from my side, I can live with that.
>
>CC:ing the syscon pdev support author: Alexander what is your
>thoughts about this? Is there a good convention to follow for
>pdev lookups?

Because the platform on which this feature was used is fully converted  to DT,
I was planning to send a patch to remove this function :)

Such usage is in my view perfectly acceptable for the period until the
platform is gradually being converted to DT, but the best way, of course,
is using syscon_regmap_lookup_by_compatible() or syscon_regmap_lookup_by_phandle().

---

��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f