Re: [PATCH 04/13] Documentation: add BCM6348 pincontroller binding documentation

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Aug 19, 2016 at 12:53 PM, Jonas Gorski <jonas.gorski@xxxxxxxxx> wrote:

> Add binding documentation for the pincontrol core found in BCM6348 SoCs.
>
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

(...)
> +pinctrl: pin-controller@fffe0080 {
> +       compatible = "brcm,bcm6348-pinctrl";
> +       reg = <0xfffe0080 0x8>,
> +             <0xfffe0088 0x8>,
> +             <0xfffe0098 0x4>;
> +       reg-names = "dirout", "dat", "mode";
> +
> +       gpio-controller;
> +       #gpio-cells = <2>;
> +};

So I would prefer if you create a syscon with two
children: the pin controller and the GPIO(s) as
separate devices using "syscon", "mfd-simple" as
compatible on the top node.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html